Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken recipes and tests due to new ESMValCore release v2.0.6b #1523

Merged
merged 6 commits into from
Feb 13, 2020

Conversation

Peter9192
Copy link
Contributor

@Peter9192 Peter9192 commented Feb 12, 2020

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • (Only if really necessary) Add any additional dependencies needed for the diagnostic script to setup.py, esmvaltool/install/R/r_requirements.txt or esmvaltool/install/Julia/julia_requirements.txt (depending on the language of your script) and also to meta.yaml for conda dependencies (includes Python and others, but not R/Julia)
  • If new dependencies are introduced, check that the license is compatible with Apache2.0

Modified recipe/diagnostic

  • Update documentation for the recipe to the doc/sphinx/source/recipes folder
  • Update provenance information if needed
  • Assign the author(s) of the affected recipe(s) as reviewer(s)

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes #1522

@Peter9192
Copy link
Contributor Author

Peter9192 commented Feb 12, 2020

Todo: Fix tests failing because the test calls fix_metadata after get_reference_levels

@Peter9192 Peter9192 mentioned this pull request Feb 12, 2020
6 tasks
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers! this is from before 2.0b6, these were happily failing yesterday too -> @jvegasbsc you owe us a beer each 🍺 😁

@bouweandela
Copy link
Member

cheers! this is from before 2.0b6, these were happily failing yesterday too -> @jvegasbsc you owe us a beer each beer

I guess it's my fault, I'll buy you guys a beer!

@bouweandela bouweandela merged commit afde4dd into master Feb 13, 2020
@bouweandela bouweandela deleted the fix_broken_recipes branch February 13, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some recipes are broken after new ESMValCore release v2.0.6b.
3 participants